Simplify to just name instead of artifactName

actions · Aug 17, 2023 · d830aca · d830aca
1 parent 22298b0
commit d830aca
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/.github/workflows/artifact-tests.yml b/.github/workflows/artifact-tests.yml
@@ -122,13 +122,13 @@ jobs:
           }
 
           const artifactNames = artifacts.map(artifact => artifact.name)
-          if (!artifactName.contains('my-artifact-ubuntu-latest')){
+          if (!artifactNames.contains('my-artifact-ubuntu-latest')){
             throw new Error('Expected artifact list to contain an artifact named my-artifact-ubuntu-latest but it did not find one')
           }
-          if (!artifactName.contains('my-artifact-windows-latest')){
+          if (!artifactNames.contains('my-artifact-windows-latest')){
             throw new Error('Expected artifact list to contain an artifact named my-artifact-windows-latest but it did not find one')
           }
-          if (!artifactName.contains('my-artifact-macos-latest')){
+          if (!artifactNames.contains('my-artifact-macos-latest')){
             throw new Error('Expected artifact list to contain an artifact named my-artifact-macos-latest but it did not find one')
           }
 

diff --git a/packages/artifact/src/internal/find/list-artifacts.ts b/packages/artifact/src/internal/find/list-artifacts.ts
@@ -72,7 +72,7 @@ export async function listArtifacts(
   // Iterate over the first page
   listArtifactResponse.artifacts.forEach(artifact => {
     artifacts.push({
-      artifactName: artifact.name,
+      name: artifact.name,
       artifactId: artifact.id,
       url: artifact.url,
       size: artifact.size_in_bytes
@@ -99,7 +99,7 @@ export async function listArtifacts(
 
     listArtifactResponse.artifacts.forEach(artifact => {
       artifacts.push({
-        artifactName: artifact.name,
+        name: artifact.name,
         artifactId: artifact.id,
         url: artifact.url,
         size: artifact.size_in_bytes

diff --git a/packages/artifact/src/internal/shared/interfaces.ts b/packages/artifact/src/internal/shared/interfaces.ts
@@ -109,7 +109,7 @@ export interface Artifact {
   /**
    * The name of the artifact
    */
-  artifactName: string
+  name: string
 
   /**
    * The ID of the artifact