Fhammerl/bump workflows node versions #1230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhammerl
commented
Nov 4, 2022
| @@ -22,12 +22,12 @@ jobs: | |||
|
|
|||
| steps: | |||
| - name: Checkout | |||
| uses: actions/checkout@v2 | |||
There was a problem hiding this comment.
Should use @V3 even though we backported the savestate filecommand fix 🤷♂️
fhammerl
commented
Nov 4, 2022
| - name: Set Node.js 12.x | ||
| uses: actions/setup-node@v1 | ||
| - name: Set Node.js 16.x | ||
| uses: actions/setup-node@v3 |
There was a problem hiding this comment.
setup-node@v3 brings an npm version that can properly handle "lockfileVersion": 2, which is what we aim to use in our package-lock files
vanZeben
approved these changes
Nov 7, 2022
|
Are you waiting for something in particular? The deprecated warnings for PRs to this repository are frustrating. |
We'll be targeting Node 16, not 14. We're looking to roll it out as soon as we can. |
|
Merged the other one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run audit-allandnpm audit --audit-level=moderate --json | scripts/audit-allow-list || npm audit --audit-level=moderate(defined inaudit.yml) are currently failing due to npm vulnerabilities.I ran
npm audit fixat root level and for the packages that failed thenpm run audit-allchecks, checked in the newpackage-lock.json.This fixed the vulnerabilities by updating to new versions, but jumping from Lerna 5.4.0 to Lerna 5.6.2 necessiates node 14 at least, so I updated our workflows to use nodev16
setup-node@v3 brings an npm version that can properly handle "lockfileVersion": 2, which is what we aim to use in our package-lock files