Add support for multi-line secrets in setSecret #1427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jww3
reviewed
May 22, 2023
jww3
reviewed
May 22, 2023
Co-authored-by: John Wesley Walker III <81404201+jww3@users.noreply.github.com>
rentziass
force-pushed
the
rentziass/set-secrets
branch
from
a492324
to
9fccf58
Compare
jww3
reviewed
May 23, 2023
jww3
approved these changes
May 23, 2023
|
Closing this in favour of #1430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #1421, the current version of
setSecretproduces unexpected behaviour when provided with a multi-line secret in that the secret isn't masked throughout the workflow logs. This splits any multi-line secret and masks each line as a single secret (documented workaround for this kind of secret).