Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing https://github.com/advisories/GHSA-f5x3-32g6-xq36 #1713

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

eggyhead
Copy link
Contributor

@eggyhead eggyhead commented Apr 10, 2024

We are failing npm validation because of GHSA-f5x3-32g6-xq36. We are updating the dependent package to fix this vulnerability.

This is marked as a breaking change in npm audit:

npm WARN audit Updating lerna to 6.4.1, which is a SemVer major change.

We use lerna for package management. I've run the following scripts to verify this update does not break our usage:

npm run audit-all
npm run bootstrap
npm run build 
npm run clean 
npm run repair 
npm run new-package [test]

I'm also updating the outdated instruction for running new-package so that it is clear for future contributors.

@eggyhead eggyhead requested a review from a team as a code owner April 10, 2024 21:41
@eggyhead eggyhead requested a review from vmjoseph April 10, 2024 21:49
@eggyhead eggyhead merged commit c104cf5 into main Apr 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants