Better Artifact Telemetry + Increase Upload chunk size #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacaovsnc
approved these changes
Jul 30, 2020
This was referenced Jun 21, 2023
at-wat
pushed a commit
to at-wat/actions-toolkit
that referenced
this pull request
Aug 31, 2023
* Differentiate user-agents for better internal telemetry * Bump chunk size from 4 to 8 MB * Update User-Agent Strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making any http calls during artifact upload or download, the user-agent string can be used to help differentiate between http-calls that get logged as part of internal telemetry. This PR changes the user-agent string to
@actions/artifact-uploadfor any call that gets made during artifact upload and@actions/artifact-downloadfor any call that gets made during download.I really wanted to leverage the package version from
package.jsonand then have the user-agent string be something like@actions/artifact-0.3.2-uploadhowever there are a host of issues reading the version number frompackage.jsonsince it's not included in therootDirfolder. More information here: https://stackoverflow.com/a/53836076I'm also bumping up the upload chunk size from 4MB to 8MB to help improve artifact upload in GHES scenarios