Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add File Commands #571

Merged
merged 6 commits into from Sep 23, 2020
Merged

Add File Commands #571

merged 6 commits into from Sep 23, 2020

Conversation

@thboop
Copy link
Collaborator

@thboop thboop commented Sep 11, 2020

No description provided.

@thboop thboop requested a review from ericsciple Sep 11, 2020
@thboop thboop force-pushed the thboop/AddFileCommands branch from fe0ee5a to 8d1441e Sep 11, 2020
docs/commands.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ericsciple ericsciple left a comment

looks good, discussed offline

thboop added 4 commits Sep 22, 2020
issueCommand('set-env', {name}, convertedVal)

const filePath = process.env['GITHUB_ENV'] || ''
if (filePath && filePath.length > 0) {

This comment has been minimized.

@ericsciple

ericsciple Sep 22, 2020
Collaborator

nit: truthy check is sufficient (ensures length > 0)

docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Outdated Show resolved Hide resolved
@thboop thboop merged commit 0759cdc into main Sep 23, 2020
12 checks passed
12 checks passed
CodeQL-Build
Details
Build (ubuntu-latest)
Details
Build (ubuntu-latest)
Details
Audit
Details
Build (ubuntu-latest)
Details
Build (windows-latest)
Details
Build (windows-latest)
Details
Build (macos-latest)
Details
Build (macos-latest)
Details
Build (macOS-latest)
Details
Build (windows-latest)
Details
CodeQL No new alerts
Details
@thboop thboop deleted the thboop/AddFileCommands branch Sep 23, 2020
tjamet added a commit to actions-go/toolkit that referenced this pull request Nov 2, 2020
Backport implementation from actions/toolkit#571
tjamet added a commit to actions-go/toolkit that referenced this pull request Nov 2, 2020
* Add SetFailedf and IsDebug helpers

SetFailedf prevents from having to use Sprintf in caller methods

* Backport new ExportVariable and SetPath

Backport implementation from actions/toolkit#571
export function toCommandValue(input: any): string {
if (input === null || input === undefined) {
return ''
} else if (typeof input === 'string' || input instanceof String) {

This comment has been minimized.

Copy link

@akkim31 akkim31 left a comment

run formet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants