-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing PR first comment or title does not trigger a workflow #27
Comments
This is expected. By default, the You need to do the following: on:
pull_request:
types: edited
issues:
issue_comment: |
Thanks @ibrasho |
I need to reopen this. I just edited my title and it is no longer triggering my action. name: Bump Version Workflow
on:
pull_request:
types: [opened, synchronize, edited, ready_for_review]
branches:
- main
workflow_dispatch:
jobs:
get-mulesoft-apps:
name: Get Mulesoft Apps
uses: VodafoneIS/mulesoft/.github/workflows/get-mulesoft-apps.yml@main
bump-version:
name: bump version
needs: get-mulesoft-apps
runs-on: ubuntu-latest
container:
image: ghcr.io/vodafoneis/mulesoft-build-image:main
credentials:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
strategy:
matrix:
MULESOFT_APP: ${{ fromJson(needs.get-mulesoft-apps.outputs.MULESOFT_APPS) }}
defaults:
run:
working-directory: ${{ matrix.MULESOFT_APP }}
steps:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.ref }}
- name: print app name
run: echo ${{ matrix.MULESOFT_APP }}
- uses: fregante/setup-git-user@v1
- name: set bump type
id: get-bump-type
run: |
bump_type=$(/scripts/get_bump_type.sh -a ${{ matrix.MULESOFT_APP }} -t ${{ github.event.pull_request.title }} -b ${{ github.event.pull_request.body}})
echo "::set-output name=BUMP_TYPE::$bump_type"
- name: bump version
run: /scripts/bump_version.sh -a ${{ matrix.MULESOFT_APP }} -b ${{ steps.get-bump-type.outputs.BUMP_TYPE }}
|
@AllanOricil - Did you ever resolve this? I am seeing the same behavior where the on:
pull_request:
types:
- opened
- edited
- reopened
- synchronize |
@obryckim I also realized I was solving the problem of bumping version in a very weird/unusual way. Looking at it now, I'm kind ashamed haha |
So, interesting update. When I have the workflow directly in a repository, with the Now, I have an organization ruleset setup where the only rule is that this workflow must pass before merging. No big deal. I am targeting 1 specific repo (for now) and all is good.
|
@obryckim if u really need to run this workflow, I think you can change |
Have the same issue as @obryckim. Why is this issue still closed 🤔 |
Same issue 😠 |
I'm trying to write an action based on this template that will check/watch the first comment of PRs. Each time the comment is edited/updated, the workflow should be executed. I tried with the following workflow:
I found that it is executed when I open a PR, respond to a PR (new comment), open an issue, respond to an issue, edit the body of the first comment of an issue, etc. However, it does not work neither when editing the first comment of a PR nor when editing the title of a PR. Therefore, it seems that the only option to trigger the workflow after the PR is created is to synchronize it again. I would expect that any of these actions would trigger
pull_request edited
,issue_comment edited
orissues edited
./cc @damccorm
The text was updated successfully, but these errors were encountered: