Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload-artifact zips .tar.gz archive #109

Open
2 of 6 tasks
n0toose opened this issue Aug 5, 2020 · 5 comments
Open
2 of 6 tasks

upload-artifact zips .tar.gz archive #109

n0toose opened this issue Aug 5, 2020 · 5 comments

Comments

@n0toose
Copy link

n0toose commented Aug 5, 2020

Describe the bug
Uploading a .tar.gz artifact results in the archive being .zipped. Many (if not probably most) projects on GitHub tend to prefer the .tar.gz extension, rather than .zip, so it most likely isn't a good idea to archive them again under a different format and/or forcing maintainers to use a specific version.

Version

  • V1
  • V2

Environment

  • self-hosted
  • Linux
  • Windows
  • Mac

Screenshots

image

Run/Repo Url
As I may take down or otherwise modify my tree at any given moment, here's the pull request in question.

How to reproduce

  • Step 1: Create .tar.gz archive in a workflow.
  • Step 2: Upload it.
  • Step 3: 🎊

Additional context
Also see: #39

@n0toose n0toose added the bug Something isn't working label Aug 5, 2020
@konradpabjan
Copy link
Collaborator

If you currently upload an any archive file (.zip, .zipx, 7z, .tar, .tar.xz etc), and then attempt to download it from the UI, the current behavior is that you'll get a zip of whatever you uploaded.

This is a limitation of our APIs and our UI, some of my earlier comments go into more details #39 (comment) and #39 (comment)

If you also look at our public api to download an artifact, you'll notice that we currently require a zip :archive_format: https://developer.github.com/v3/actions/artifacts/#download-an-artifact and that is what effectively is being used when you click to download an artifact. Ideally we should have options that let get the raw contents of whatever was uploaded without any archiving format, but we currently don't have any solutions 😞

@sagikazarmark
Copy link

@konradpabjan is this behavior going to change at some point or we are stuck with it for life? It's unclear from your comments.

(I get that it's not a limitation of this action, but this is where users are affected, so I think it would make sense to post some updates here or envolve someone who works on the API.)

@konradpabjan
Copy link
Collaborator

konradpabjan commented Sep 25, 2020

@sagikazarmark

We absolutely have plans to address this, it's on our backlog but there are other priorities that are currently preventing us from picking up the work. Our public roadmap has some high level priorities for Actions for those curious: https://github.com/github/roadmap/projects/1

The experience right now leaves a lot to be desired and an overhaul for the Artifacts UI + better API support has come up in internal discussions multiple times. We're definitely planning on addressing this.

nistei added a commit to flybywiresim/aircraft that referenced this issue Mar 6, 2021
nistei added a commit to flybywiresim/aircraft that referenced this issue Mar 6, 2021
Benjozork pushed a commit to flybywiresim/aircraft that referenced this issue Mar 6, 2021
* chore: update fragmenter package

* build: use PR action for testing

* build: revert fragmenter and don't use dev-env for zip build

* build: upload modules as artifact

* fix: typo in lftp options

* build: remove ascii option

* build: use fragmenter output for artifacts

* build: remove fragmenter from PR action

* fix(ci): remove ascii option

* build: zip before artifact upload

refs: actions/upload-artifact#109
sarcasticadmin added a commit to socallinuxexpo/scale-network that referenced this issue Aug 30, 2021
The upload workflow within github actions leaves a lot to be desired.
There were many initial assumptions with GITHUB_WORKSPACE, paths from
test repos, etc. that were originally left here. These more or less have
been vetted now and this is the best result I have found to date for
scale-network.

Additionally, I am watching a few upstream stories in the upload actions
repo just to see if it improves things for us in the near term:
  - actions/upload-artifact#109
  - actions/upload-artifact#21
sarcasticadmin added a commit to socallinuxexpo/scale-network that referenced this issue Aug 30, 2021
The upload workflow within github actions leaves a lot to be desired.
There were many initial assumptions with GITHUB_WORKSPACE, paths from
test repos, etc. that were originally left here. These more or less have
been vetted now and this is the best result I have found to date for
scale-network.

Additionally, I am watching a few upstream stories in the upload actions
repo just to see if it improves things for us in the near term:
  - actions/upload-artifact#109
  - actions/upload-artifact#21
@awakecoding
Copy link

+1 on this, I compress all my artifacts to .tar.xz but I have no choice but to download them as .zip files that I have to unzip to recover the already-compressed .tar.xz artifact. Is this going to be fixed anytime soon? It's a pain

sarcasticadmin added a commit to socallinuxexpo/scale-network that referenced this issue Oct 2, 2021
The upload workflow within github actions leaves a lot to be desired.
There were many initial assumptions with GITHUB_WORKSPACE, paths from
test repos, etc. that were originally left here. These more or less have
been vetted now and this is the best result I have found to date for
scale-network.

Additionally, I am watching a few upstream stories in the upload actions
repo just to see if it improves things for us in the near term:
  - actions/upload-artifact#109
  - actions/upload-artifact#21
@fregante
Copy link

fregante commented Oct 27, 2021

This is basically a duplicate of:

The solution for both would be to avoid zipping "compressed archives"

agraef added a commit to agraef/pd-faustgen that referenced this issue Jan 22, 2023
Yes, it's a tarball. But due to limitations in the GH API, at present it
will be wrapped in a zip file.

cf. actions/upload-artifact#109
agraef added a commit to agraef/pd-faustgen that referenced this issue Jan 22, 2023
Yes, it's a tarball. But due to limitations in the GH API, at present it
will be wrapped in a zip file.

cf. actions/upload-artifact#109
mattstruble added a commit to mattstruble/zero-router that referenced this issue Nov 29, 2023
It was originally thought that by adding the extension .img.gz would
allow for the downloaded artifact to not be double zipped. However, this
seems to be a bug in github, which can be tracked via:

actions/upload-artifact#39
actions/upload-artifact#109

Signed-off-by: Matt Struble <mattstruble@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants