Document relative paths rooted against workspace #318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why was this closed? It seems like a good clarification to me. |
|
Because I accidentally deleted my fork. But it did sit there without any activity for five months. Maybe try to recreate it and see if you have more luck? |
kireerik
added a commit
to kireerik/upload-artifact
that referenced
this pull request
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation currently states that "Relative paths are rooted against the current working directory". This can lead a caller to think that the default working-directory applies to this action whereas it does not (the
defaultworking-directoryonly applies to therunsteps).I reworded the sentence to state "Relative paths are rooted against the workspace." which I think is clearer.
Fix #294 fix #246 fix #87