Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipelines without an explicit pool do not work #4302

Closed
1 of 8 tasks
thhous-msft opened this issue Oct 18, 2021 · 3 comments
Closed
1 of 8 tasks

Pipelines without an explicit pool do not work #4302

thhous-msft opened this issue Oct 18, 2021 · 3 comments
Labels
bug Something isn't working external

Comments

@thhous-msft
Copy link

Description

We have a pipeline without an explicit pool, which just uses whatever the default image is. It seems like the default is still set to Ubuntu16, which causes all projects without an explicit image set to fail.

Virtual environments affected

  • Ubuntu 16.04
  • Ubuntu 18.04
  • Ubuntu 20.04
  • macOS 10.15
  • macOS 11
  • Windows Server 2016
  • Windows Server 2019
  • Windows Server 2022

Image version and build link

https://dev.azure.com/ms/msquic/_build/results?buildId=231784&view=logs&j=1563c887-691d-50af-ad2f-c88bbc874cfc

The distribution task.

Is it regression?

Yes

Expected behavior

Task without pool to run on some default image

Actual behavior

Task fails to run with ##[warning]An image label with the label Ubuntu16 does not exist.

Repro steps

Create a pipeline with no explicit pool. This pipeline can do anything. The pipeline will fail to run.

@thhous-msft
Copy link
Author

Based on #3287, it looks like the default pool should have been changed before the removal, but it doesn't seem to have been.

@al-cheb al-cheb added bug Something isn't working external and removed needs triage labels Oct 19, 2021
@ghost
Copy link

ghost commented Oct 19, 2021

We just got this error also, if you don't specify pool: vmImage: 'ubuntu-latest', it defaults to Ubuntu16 at says it can't find it.

@miketimofeev
Copy link
Contributor

@thhous-msft I've seen you have already fixed the issue in this commit microsoft/msquic@5cae356#diff-2b2036ac382f25e39eba250eb68a4159e645997c460a4844774247a903b59380
Another possible fix is to set the default agent pool for YAML to Azure Pipelines — this allows you to skip specifying vmImage in the yaml:
image
Using REST API is probably the easiest way to update all the pipelines https://docs.microsoft.com/en-us/rest/api/azure/devops/build/definitions/update-definition?view=vsts-rest-tfs-4.1
The script could be like this:

var u16pipelines = GetAllDefinitionsWithHostedUbuntu16QueueId();
var newQueue = GetQueue("NewQueueName");
foreach(def in u16pipelines)
{
  def.QueueId = newQueue.Id;
  UpdateDefinition(def);
}

@bogdandascalu-endava I believe you have pretty the same issue, please follow the advice above.

I'm going to close the issue as there is not much we can do here from our side.
Please feel free to contact us if you have any concerns.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external
Projects
None yet
Development

No branches or pull requests

3 participants