[refactor]: (SqlExecWorkflow) Detail module #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2024
Rain-1214
reviewed
May 22, 2024
| return 'none'; | ||
| } | ||
| return 'hidden'; | ||
| }); |
There was a problem hiding this comment.
这个逻辑可以改一改来适配严格模式吧？这个分支里只有v 原值是show的时候才设置为hidden，原值是undefined的时候才设置为none。
There was a problem hiding this comment.
可以先合进去，我在后面补这个组件单元测试的时候调整么？现在这个pr的 ci 还没过，后面的 pr 里改的。。
| } | ||
| } | ||
|
|
||
| animation: slideAndHide 300ms; |
There was a problem hiding this comment.
这个动画光自定义from的tranform没啥意义吧？不如直接放在这个animation属性里？反正@Keyframes它可以在外面自己写。就它有个默认动画，不想用这个默认动画它就自己定义动画，然后把动画名传进来，
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue 地址：actiontech/sqle#2429
重构 工单详情模块
调整 创建、列表部分组件
遗留事项：语言包、主题、单元测试验证以及补充单元测试、重构文档说明
assign in @Rain-1214