Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test]: fix] Refine data export styles and implement unit tests #329

Merged
merged 3 commits into from
May 29, 2024

Conversation

LZS911
Copy link
Collaborator

@LZS911 LZS911 commented May 29, 2024

actiontech/sqle#2429

修复重构后数据导出样式错误的问题。

补充 部分组件的单元测试

使用 LazyLoadComponent 替换创建工单流程中 表单、审核结果、创建结果三个组件通过 hidden 隐藏方式。

使用 LazyLaodComponent 替换 SQL 上传方式时使用 EmptyBox 来控制组件隐藏方式,同时调整 上传方式组件的表单验证。(之前检验的 required 一直为 true, 改为 LazyLaodComponent 后 required 该为和 LazyLaodComponent 的 open 属性同步,即只在组件渲染后才进行检验)

@LZS911 LZS911 marked this pull request as draft May 29, 2024 02:53
Copy link

github-actions bot commented May 29, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 96.45% 11395/11814
🟢 Branches 80.23% 4366/5442
🟢 Functions 96.19% 4237/4405
🟢 Lines 96.98% 11173/11521

Test suite run success

1971 tests passing in 565 suites.

Report generated by 🧪jest coverage report action from 16dae69

…a based on the SQL upload type during review
@LZS911 LZS911 marked this pull request as ready for review May 29, 2024 05:54
@anny1021 anny1021 merged commit 971e02f into main May 29, 2024
9 checks passed
@anny1021 anny1021 deleted the test/refactor-workflow-unit-tests branch May 29, 2024 06:10
@anny1021 anny1021 restored the test/refactor-workflow-unit-tests branch May 29, 2024 06:10
@anny1021 anny1021 deleted the test/refactor-workflow-unit-tests branch May 29, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants