Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binlog dump thread leaks #220

Closed
actiontech-bot opened this issue Sep 4, 2018 · 2 comments
Closed

binlog dump thread leaks #220

actiontech-bot opened this issue Sep 4, 2018 · 2 comments
Labels

Comments

@actiontech-bot
Copy link
Member

Description

Steps to reproduce the issue:

  1. set up a replication
  2. delete the job, or kill dtle

Describe the results you received:
MySQL binlog dump thread will still exists for minutes

Describe the results you expected:

Output of ./dtle version:

(not available)

Additional information you deem important (e.g. issue happens only occasionally):

Additional details (log, config, job config etc):

@actiontech-bot actiontech-bot added wontfix This will not be worked on migrated labels Sep 4, 2018
@actiontech actiontech deleted a comment from actiontech-bot Mar 29, 2019
@ghost
Copy link

ghost commented Mar 29, 2019

fixed in 385c441.

It is mainly affected by HeartbeatPeriod when setting up streaming.

Test shows that the dump thread will be closed when

  • terminating dtle
  • pausing a job
  • deleting a job

@ghost ghost removed the wontfix This will not be worked on label Sep 3, 2019
@ghost
Copy link

ghost commented Sep 3, 2019

  • HeartbeatPeriod: mysql sends heart beat packet at this period
  • ReadTimeout: client disconnect if no packet received for this timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant