Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

新增审核规则背景解释 #1124

Closed
sjjian opened this issue Nov 21, 2022 · 1 comment · Fixed by actiontech/sqle-ui#153
Closed

新增审核规则背景解释 #1124

sjjian opened this issue Nov 21, 2022 · 1 comment · Fixed by actiontech/sqle-ui#153
Assignees
@LZS911 @taolx0
Labels
feature not_compatible not compatible old version ui this issue is is related to the FE verified the issue all pr is verified
Milestone
v2.2211.0

Comments

@sjjian
Copy link
Member

sjjian commented Nov 21, 2022 •
edited by ColdWaterLW

需求

  1. 新增规则背景解释，并在SQLE的规则，配置规则的界面展示；

在全局规则页面和规则模板编辑页面用灰色的文字添加一行规则背景，展示一定数量的字符，多的用省略号，当鼠标悬停在灰色字符上时，浮窗展示全部的内容
image

编辑规则时展示完整的背景内容
image

要求

  1. 需要考虑审核插件的支持
@sjjian sjjian added the feature label Nov 21, 2022
@sjjian sjjian added this to the v2.2211.0 milestone Nov 21, 2022
@taolx0 taolx0 mentioned this issue Nov 21, 2022
Merged
@ColdWaterLW ColdWaterLW added the ui this issue is is related to the FE label Nov 21, 2022
@taolx0 taolx0 mentioned this issue Nov 21, 2022
Merged
@LZS911 LZS911 mentioned this issue Nov 22, 2022
Merged
This was referenced Nov 24, 2022
Merged
Merged
@ColdWaterLW ColdWaterLW reopened this Nov 25, 2022
@LZS911 LZS911 mentioned this issue Nov 25, 2022
Merged
@sjjian sjjian added the not_compatible not compatible old version label Nov 28, 2022
@sjjian sjjian closed this as completed Nov 28, 2022
@HuangWeiCen HuangWeiCen mentioned this issue Nov 30, 2022
Closed
@Marcus9530
Copy link
Collaborator

验证版本
UI Version: main ff420bf
Server Version: main 0099984
验证步骤
查看mysql类型的审核规则，当前已实现的审核规则都已经新增了规则背景说明

image

image

@Marcus9530 Marcus9530 added the verified the issue all pr is verified label Dec 2, 2022
LordofAvernus pushed a commit that referenced this issue Oct 24, 2023
@rocky114
Merge pull request #1124 from actiontech/fix_wrong_url
fcc9fa0 
fix wrong url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LZS911 LZS911

@taolx0 taolx0

Labels
feature not_compatible not compatible old version ui this issue is is related to the FE verified the issue all pr is verified
Projects
None yet
Milestone
v2.2211.0
Development

Successfully merging a pull request may close this issue.

[feature]: add rule annotation and rewrite the edit rule form using BackendForm actiontech/sqle-ui
5 participants
@sjjian @ColdWaterLW @LZS911 @Marcus9530 @taolx0