primary_key unsettable with has_many

[jgillman]

foreign_key works just fine, but primary_key always uses id.

Given the following:

# app/models/state.rb
class State < ActiveHash::Base
  include ActiveHash::Associations
  has_many :cities, primary_key: 'abbrev', foreign_key: 'state'

  self.data = [
    { id: 1, name: "California", abbrev: "CA" }
  ]
end

# app/models/city.rb
class City < ActiveRecord::Base
  ... # city.state would be "CA"
end

The following will fail because it looks for the value id and not abbrev

s = State.find_by_name "California"
s.cities

The above would run something like:

SELECT "cities".* FROM "cities"  WHERE "cities"."state" = 1

When it should run:

SELECT "cities".* FROM "cities"  WHERE "cities"."state" = "CA"

I believe it should be fairly easy to add it to lib/associations/associations.rb but I'm pretty green and unsure of all the implications.

[zilkey]

This seems like an intuitive patch. Before I think about how it might be implemented, could you just use the abbreviation as the id? That is, do you store the id anywhere in the db?

ActiveHash should work fine with string ids (see https://github.com/zilkey/active_hash/blob/master/spec/active_hash/base_spec.rb#L366)

Would that suit your current situation?

[tomtaylor]

This'd be great. We're migrating a bunch of databased based models to use ActiveHash, and this would help us simplify the transition.

[zilkey]

Released in v1.2.0

[jgillman]

Woo! Thanks @tomtaylor 👍