WIP rails 5 support #114
Merged
WIP rails 5 support #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fivell
force-pushed
the
rails5
branch
4 times, most recently
from
a5f79bb
to
6ad4c55
Compare
| @@ -63,7 +63,7 @@ def active_admin_import(options = {}, &block) | |||
|
|
|||
| collection_action :do_import, method: :post do | |||
| authorize!(ActiveAdminImport::Auth::IMPORT, active_admin_config.resource_class) | |||
|
|
|||
| params = ActiveSupport::HashWithIndifferentAccess.new params.respond_to?(:to_unsafe_h) ? params.to_unsafe_h : params | |||
Fivell
force-pushed
the
rails5
branch
2 times, most recently
from
8c5c6d0
to
4c3990c
Compare
| @@ -63,7 +63,8 @@ def active_admin_import(options = {}, &block) | |||
|
|
|||
| collection_action :do_import, method: :post do | |||
| authorize!(ActiveAdminImport::Auth::IMPORT, active_admin_config.resource_class) | |||
|
|
|||
| _params = params.respond_to?(:to_unsafe_h) ? params.to_unsafe_h : params | |||
There was a problem hiding this comment.
Do not use prefix _ for a variable that is used.
Fivell
force-pushed
the
rails5
branch
5 times, most recently
from
77055d4
to
9ff29fd
Compare
| @@ -63,7 +63,8 @@ def active_admin_import(options = {}, &block) | |||
|
|
|||
| collection_action :do_import, method: :post do | |||
| authorize!(ActiveAdminImport::Auth::IMPORT, active_admin_config.resource_class) | |||
|
|
|||
| _params = params.respond_to?(:to_unsafe_h) ? params.to_unsafe_h : params | |||
There was a problem hiding this comment.
Do not use prefix _ for a variable that is used.
| inject_into_file "app/models/author.rb", " validates_presence_of :name\n validates_uniqueness_of :last_name\n", after: "Base\n" | ||
| inject_into_file "app/models/post.rb", " validates_presence_of :author\n", after: ":author\n" | ||
| inject_into_file "app/models/author.rb", " validates_presence_of :name\n validates_uniqueness_of :last_name\n", before: "end" | ||
| inject_into_file "app/models/post.rb", " validates_presence_of :author\n", before: "end" |
… no support in active_admin
|
fixes #91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.