Rails 5 mongoid 6 #105
Merged
Rails 5 mongoid 6 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version caused 3 query: 1. collection.empty? => load an item to ensure there are items in the collection 2. collection.first ... => again load an item to be sure about we querying mongo 3. collection.count(true) => actual count command
With this approach mongoid will fire only one count query
…ngoid into pencilcheck-patch-1 Conflicts: lib/active_admin/mongoid/helpers/collection.rb
…nto rails-5-mongoid-6
elia
approved these changes
Jun 9, 2017
activeadmin-mongoid.gemspec
Outdated
| gem.add_runtime_dependency 'mongoid', ['> 3.0', '< 5.0'] | ||
| gem.add_runtime_dependency 'activeadmin', ['>= 1.0.0.pre', '< 2'] | ||
| gem.add_runtime_dependency 'mongoid', ['>= 6.0', '< 6.1'] | ||
| gem.add_runtime_dependency 'activeadmin', ['>= 1.0.0.pre5', '< 2'] |
There was a problem hiding this comment.
@boie0025 what about just using ~> 1.0 here?
|
@boie0025 Are you going to merge? |
|
Yes, doing a bit more testing in our on this before we pull it into master. Will merge and release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for Mongoid 6,update readme, pull in older fixes for misc bugs and green specs on rails 5.0.x and mongoid 6.0.x