Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

columns works for Page, but not Resource #3711

Closed
seanlinsley opened this issue Dec 27, 2014 · 1 comment
Closed

columns works for Page, but not Resource #3711

seanlinsley opened this issue Dec 27, 2014 · 1 comment
Labels

Comments

@seanlinsley
Copy link
Contributor

Given this configuration:

ActiveAdmin.register Client do
  show do
    columns do
      column do
      end
    end
  end
end

You get this error:

NoMethodError - undefined method `span_size' for #<ActiveAdmin::Views::Panel:0x00000108801778>:
  arbre (1.0.2) lib/arbre/element.rb:182:in `method_missing'
  activeadmin-b794f4b7550d/lib/active_admin/views/components/columns.rb:105:in `block in columns_span_count'
  activeadmin-b794f4b7550d/lib/active_admin/views/components/columns.rb:105:in `columns_span_count'
  activeadmin-b794f4b7550d/lib/active_admin/views/components/columns.rb:91:in `calculate_columns!'
  activeadmin-b794f4b7550d/lib/active_admin/views/components/columns.rb:75:in `add_child'
  arbre (1.0.2) lib/arbre/element/builder_methods.rb:40:in `insert_tag'
  arbre (1.0.2) lib/arbre/element/builder_methods.rb:14:in `panel'
  app/admin/client.rb:22:in `block (3 levels) in <top (required)>'
  arbre (1.0.2) lib/arbre/element/builder_methods.rb:31:in `block in build_tag'
  arbre (1.0.2) lib/arbre/context.rb:92:in `with_current_arbre_element'
  arbre (1.0.2) lib/arbre/element/builder_methods.rb:49:in `with_current_arbre_element'
  arbre (1.0.2) lib/arbre/element/builder_methods.rb:26:in `build_tag'
  arbre (1.0.2) lib/arbre/element/builder_methods.rb:39:in `insert_tag'
  arbre (1.0.2) lib/arbre/element/builder_methods.rb:14:in `columns'
  app/admin/client.rb:21:in `block (2 levels) in <top (required)>'

Which isn't what you expect given the columns DSL on pages like the dashboard.

@bsvin33t
Copy link
Contributor

bsvin33t commented Apr 6, 2015

Hi @seanlinsley I have created a PR for the above error. It is #3878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants