Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Baremetrics datepicker #4034

Closed
seanlinsley opened this issue Jul 20, 2015 · 6 comments
Closed

Consider using Baremetrics datepicker #4034

seanlinsley opened this issue Jul 20, 2015 · 6 comments

Comments

@seanlinsley
Copy link
Contributor

Baremetrics' datepicker is the best I've seen so far. We might want to consider vendoring it as the default.

Github: https://github.com/Baremetrics/calendar

Demo: http://baremetrics.github.io/calendar/

screen shot 2015-07-19 at 11 56 29 pmscreen shot 2015-07-19 at 11 56 54 pm

@timoschilling
Copy link
Member

look's nice, but I think we should not depend on a UI gem, do everyone can make it's own choice.

@seanlinsley
Copy link
Contributor Author

@timoschilling while we shouldn't prevent them from using what they want, we should provide something by default that looks good and works well. I think Baremetrics' datepicker makes more sense than the jQuery UI datepicker we're currently using.

@timoschilling
Copy link
Member

@seanlinsley I understand you, but we jQuery UI, if some want something else he can use it. or can use activeadmin-baremetrics.

@seanlinsley
Copy link
Contributor Author

We only use jQuery UI because it's convenient. That shouldn't stop us from using the best possible tools available.

@deivid-rodriguez
Copy link
Member

I don't think we should worry about this kind of things at this stage. But if we were to start changing this dependencies, so should move towards little standalone utilities that don't depend on jquery.

Here, for example, https://github.com/chmln/flatpickr.

So I vote to close this.

@varyonic
Copy link
Contributor

We have a couple of date picker plugins already, building another with this widget would be a good project for someone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants