Skip to content

Commit

Permalink
Remove upper bound dependency limits from gemspec (#539)
Browse files Browse the repository at this point in the history
Remove upper bound limit from our dependencies

All that was needed to support Rails 7 in this gem was to update the
gemspec. This means that even in the most likely release to break
anything, a major release, we didn't needed to worry about breaking this
gem.

This upper bound is just creating unnecessary work for the
maintainers of this gem, which would need to release it without any code
change, and the users, which need to open issues asking for new releases.

Let's allow our users to try any version of our dependencies and report
real issues if they find them, and save everyone's time just removing
the upper bound.
  • Loading branch information
javierjulio committed Oct 6, 2023
1 parent f96a808 commit 5f9cc4e
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 10 deletions.
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ PATH
remote: .
specs:
arbre (1.6.0)
activesupport (>= 3.0.0, < 7.1)
ruby2_keywords (>= 0.0.2, < 1.0)
activesupport (>= 3.0.0)
ruby2_keywords (>= 0.0.2)

GEM
remote: http://rubygems.org/
Expand Down
4 changes: 2 additions & 2 deletions arbre.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ Gem::Specification.new do |s|

s.required_ruby_version = '>= 2.7'

s.add_dependency("activesupport", ">= 3.0.0", "< 7.1")
s.add_dependency("ruby2_keywords", ">= 0.0.2", "< 1.0")
s.add_dependency("activesupport", ">= 3.0.0")
s.add_dependency("ruby2_keywords", ">= 0.0.2")
end
4 changes: 2 additions & 2 deletions gemfiles/rails_61/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ PATH
remote: ../..
specs:
arbre (1.6.0)
activesupport (>= 3.0.0, < 7.1)
ruby2_keywords (>= 0.0.2, < 1.0)
activesupport (>= 3.0.0)
ruby2_keywords (>= 0.0.2)

GEM
remote: http://rubygems.org/
Expand Down
4 changes: 0 additions & 4 deletions spec/gemspec_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@
end
end

it "has no warnings" do
expect(build[1]).not_to include("WARNING")
end

it "succeeds" do
expect(build[2]).to be_success
end
Expand Down

0 comments on commit 5f9cc4e

Please sign in to comment.