Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider e.printStackTrace and add logging #9

Closed
grobmeier opened this issue Apr 25, 2018 · 2 comments
Closed

Reconsider e.printStackTrace and add logging #9

grobmeier opened this issue Apr 25, 2018 · 2 comments
Assignees

Comments

@grobmeier
Copy link
Contributor

At this line:
https://github.com/wildbit/postmark-java/blob/master/src/main/java/com/wildbit/java/postmark/Postmark.java#L51

the stack trace is written to console. In clustered environments this message could get lost, as the console output is disabled. Logging messages are usually directed using a logging framework.

One dependency is already using slf4j:

[INFO] +- eu.medsea.mimeutil:mime-util:jar:2.1.3:compile
[INFO] |  +- org.slf4j:slf4j-api:jar:1.5.6:compile
[INFO] |  +- org.slf4j:slf4j-log4j12:jar:1.5.6:runtime
[INFO] |  \- log4j:log4j:jar:1.2.14:runtime

Unfortunately it's an older version. Another option would be to use JUL directly. However, usually slf4j is being used as it's compatible with all major frameworks and is also offering basic logging for those who don't want to include them.

@ibalosh
Copy link
Contributor

ibalosh commented Apr 26, 2018

agreed, will consider it in next release

tx!

@ibalosh ibalosh self-assigned this May 15, 2018
@ibalosh
Copy link
Contributor

ibalosh commented May 29, 2018

should be resolved in 1.1.4 version

@ibalosh ibalosh closed this as completed May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants