Fix ignoreKeys parameter in compareWithBaseFile function and optimize…

… handleHotUpdate function
activeguild · Feb 19, 2024 · ce83035 · ce83035
1 parent 4cc703a
commit ce83035
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/checker.ts b/src/checker.ts
@@ -4,7 +4,7 @@ export const compareWithBaseFile = (
   prohibitedKeys?: string[],
   prohibitedValues?: string[],
   ignoreKeysFilter?: (id: unknown) => boolean,
-  ignoreKeys: RegExp | RegExp[] | undefined
+  ignoreKeys?: RegExp | RegExp[] | undefined
 ) => {
   const errors: string[] = [];
   for (let i = 0; i < cachedBaseFile.length; i++) {

diff --git a/src/index.ts b/src/index.ts
@@ -156,9 +156,7 @@ export default async function Plugin(
       }
     },
     async handleHotUpdate(context) {
-      const text = await context.read();
-      const json = JSON.parse(text);
-
+      let json: any = null;
       for (let i = 0; i < finalOptions.length; i++) {
         const finalOption = finalOptions[i];
         if (!finalOption.cachedBaseFile) {
@@ -170,6 +168,8 @@ export default async function Plugin(
         }
 
         if (context.file === finalOption.baseLocaleFilePath) {
+          const text = await context.read();
+          json = JSON.parse(text);
           finalOption.cachedBaseFile = traverse(json);
         }