Set group context on all rewritten URLs, not just those in the group #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@freelock 👍 this is key for our use of this module |
|
@rbran100 our project has been on hold, but there is definitely more work to do on this... @bezhermoso can we get some review/merging, to get this closer to a useful state? |
freelock
pushed a commit
to freelock/purl-d8
that referenced
this pull request
Oct 16, 2021
Fixed route caching issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outbound URL rewriting adds the group path to each URL. However, it does not set a cache context for these rewritten links -- so if you go to a different Purl context, you get cached links from the first context that generated the links, until you clear the cache.
CacheContext was already set correctly for links within a group, just not for the other rewritten links.
This PR adds a cache context to all URLs generated on a page, if there's an active Purl context.