Empty extend fix #1335
Empty extend fix #1335
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## main #1335 +/- ##
==========================================
- Coverage 91.80% 90.85% -0.95%
==========================================
Files 151 146 -5
Lines 10820 10484 -336
==========================================
- Hits 9933 9525 -408
- Misses 887 959 +72
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -794,3 +794,13 @@ def test_tobytes(memory_ds, compressed_image_paths, audio_paths): | |||
| for i in range(3): | |||
| assert ds.image[i].tobytes() == image_bytes | |||
| assert ds.audio[i].tobytes() == audio_bytes | |||
|
|
|||
|
|
|||
| def test_empty_extend(memory_ds): | |||
There was a problem hiding this comment.
Please add a doc line like "test extend empty tensor" or rename the test to something like test_extend_empty_tensor
There was a problem hiding this comment.
We are not testing extending an empty tensor, but rather extending a tensor with an empty list/array.
| ds.x.append(1) | ||
| ds.create_tensor("y") | ||
| ds.y.extend(np.zeros((len(ds), 3))) | ||
| assert len(ds) == 0 |
There was a problem hiding this comment.
What is the expected len(ds.y) here? Please add assertion.
|
Moved to #1365 |
🚀 🚀 Pull Request
Checklist:
coverage-rateupChanges
Fixes dataset corruption when extending with empty list / array
https://activeloop.atlassian.net/browse/AL-1418