minor comments

activeloopai · Jul 21, 2021 · 19160c5 · 19160c5
1 parent f447bda
commit 19160c5
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 27 deletions.
diff --git a/hub/api/info.py b/hub/api/info.py
@@ -1,5 +1,4 @@
 from hub.core.storage.lru_cache import LRUCache
-from hub.util.json import validate_is_jsonable
 from typing import Any, Dict
 from hub.core.storage.cachable import CachableCallback, use_callback
 

diff --git a/hub/constants.py b/hub/constants.py
@@ -35,11 +35,11 @@
 DEFAULT_LOCAL_CACHE_SIZE = 0
 
 
-# meta is 100% required hub-defined meta
+# meta is hub-defined information, necessary for hub Datasets/Tensors to function
 DATASET_META_FILENAME = "dataset_meta.json"
 TENSOR_META_FILENAME = "tensor_meta.json"
 
-# info is 100% optional user-defined information
+# info is user-defined information, entirely optional. may be used by the visualizer
 DATASET_INFO_FILENAME = "dataset_info.json"
 TENSOR_INFO_FILENAME = "tensor_info.json"
 

diff --git a/hub/core/storage/cachable.py b/hub/core/storage/cachable.py
@@ -86,9 +86,9 @@ def __init__(self):
         self._cache = None
 
     def _is_callback_initialized(self) -> bool:
-        key_ex = self._key is not None
-        cache_ex = self._cache is not None
-        return key_ex and cache_ex
+        key_exists = self._key is not None
+        cache_exists = self._cache is not None
+        return key_exists and cache_exists
 
     def initialize_callback_location(self, key, cache):
         """Must be called once before any other method calls.

diff --git a/hub/util/json.py b/hub/util/json.py