Merge pull request #2345 from activeloopai/fy_fix_iter

[AL-2280] Fix numpy slowdown with iteration and groups
activeloopai · May 12, 2023 · 3dd678b · 3dd678b
2 parents 266e1e8 + ab55a29
commit 3dd678b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/deeplake/api/tests/test_api.py b/deeplake/api/tests/test_api.py
@@ -2457,3 +2457,16 @@ def test_sequence_numpy_bug(memory_ds):
             ds.abc.numpy()
 
         assert ds.abc.numpy(aslist=True) == [[1, 2], [1, 2, 3], [1, 2, 3, 4]]
+
+
+def test_iterate_with_groups(memory_ds):
+    with memory_ds as ds:
+        ds.create_tensor("x/y/z")
+
+    ds["x/y/z"].extend(list(range(100)))
+
+    for i, sample in enumerate(ds):
+        assert sample["x/y"].z.is_iteration == True
+
+    for i, sample in enumerate(ds):
+        assert sample["x/y/z"].is_iteration == True
diff --git a/deeplake/core/dataset/dataset.py b/deeplake/core/dataset/dataset.py
@@ -489,6 +489,7 @@ def __getitem__(
                     verbose=False,
                     version_state=self.version_state,
                     path=self.path,
+                    is_iteration=is_iteration,
                     link_creds=self.link_creds,
                     pad_tensors=self._pad_tensors,
                     enabled_tensors=self.enabled_tensors,