-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[small] Update/2.0/hub cloud test #1023
Conversation
will be updating fixtures soon |
Codecov Report
@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
- Coverage 88.66% 88.62% -0.05%
==========================================
Files 85 85
Lines 3918 3920 +2
==========================================
Hits 3474 3474
- Misses 444 446 +2
Continue to review full report at Codecov.
|
Would be great to switch to dev in order to avoid uploading bunch of test datasets to production. Check this https://github.com/activeloopai/dataflow/blob/master/backend/api/tests/fixtures/datasetv2.py#L12 Instead you would need to have
and activeloop credentials should for development (not production) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to switch to dev in order to avoid uploading bunch of test datasets to production.
Check this https://github.com/activeloopai/dataflow/blob/master/backend/api/tests/fixtures/datasetv2.py#L12
Instead you would need to have
hub.client.config.DEV = True
...
and activeloop credentials should for development (not production)
It is fine to add a production read-only test.
@davidbuniat that's a good suggestion, but outside the scope of this PR. if there's nothing wrong with this PR let's get it approved |
@mccrearyd adding test datasets to the production is wrong :) then it would be hustle to clean up in backend if the upload fails (not only in storage) |
made test go accross 2 chunks and cleaned it up a little bit