Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[small] Update/2.0/hub cloud test #1023

Merged
merged 3 commits into from Jul 12, 2021
Merged

Conversation

verbose-void
Copy link
Contributor

made test go accross 2 chunks and cleaned it up a little bit

@verbose-void verbose-void added the v2 Everything related to Hub v2 label Jul 7, 2021
@verbose-void verbose-void self-assigned this Jul 7, 2021
@verbose-void
Copy link
Contributor Author

will be updating fixtures soon

@verbose-void verbose-void changed the title Update/2.0/hub cloud test [small] Update/2.0/hub cloud test Jul 7, 2021
@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #1023 (3d90563) into main (fa8e734) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
- Coverage   88.66%   88.62%   -0.05%     
==========================================
  Files          85       85              
  Lines        3918     3920       +2     
==========================================
  Hits         3474     3474              
- Misses        444      446       +2     
Impacted Files Coverage Δ
hub/api/tests/test_api.py 99.08% <100.00%> (+<0.01%) ⬆️
hub/api/dataset.py 87.23% <0.00%> (-1.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8e734...3d90563. Read the comment docs.

@davidbuniat
Copy link
Member

Would be great to switch to dev in order to avoid uploading bunch of test datasets to production.

Check this https://github.com/activeloopai/dataflow/blob/master/backend/api/tests/fixtures/datasetv2.py#L12

Instead you would need to have

hub.client.config.DEV = True
...

and activeloop credentials should for development (not production)

Copy link
Member

@davidbuniat davidbuniat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to switch to dev in order to avoid uploading bunch of test datasets to production.

Check this https://github.com/activeloopai/dataflow/blob/master/backend/api/tests/fixtures/datasetv2.py#L12

Instead you would need to have

hub.client.config.DEV = True
...

and activeloop credentials should for development (not production)

It is fine to add a production read-only test.

@verbose-void
Copy link
Contributor Author

@davidbuniat that's a good suggestion, but outside the scope of this PR. if there's nothing wrong with this PR let's get it approved

@davidbuniat
Copy link
Member

@mccrearyd adding test datasets to the production is wrong :) then it would be hustle to clean up in backend if the upload fails (not only in storage)

@verbose-void verbose-void merged commit 47a67e8 into main Jul 12, 2021
@verbose-void verbose-void deleted the update/2.0/hub-cloud-test branch July 12, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 Everything related to Hub v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants