Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[small] pytorch readonly error bug fix #1026

Merged
merged 6 commits into from Jul 12, 2021
Merged

Conversation

verbose-void
Copy link
Contributor

please also review #1024 as this branch is based on it and they're both really small

if you tried to use pytorch on a dataset in readonly mode it would fail. this fixes it and adds a test for future proof

@verbose-void verbose-void added bug Something isn't working v2 Everything related to Hub v2 labels Jul 8, 2021
@verbose-void verbose-void self-assigned this Jul 8, 2021
Copy link
Contributor

@AbhinavTuli AbhinavTuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change required.

Base automatically changed from fix/2.0/readonly to main July 9, 2021 17:29
@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #1026 (80571bb) into main (94b43ea) will increase coverage by 0.00%.
The diff coverage is 90.90%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1026   +/-   ##
=======================================
  Coverage   88.61%   88.61%           
=======================================
  Files          86       87    +1     
  Lines        3916     3936   +20     
=======================================
+ Hits         3470     3488   +18     
- Misses        446      448    +2     
Impacted Files Coverage Δ
hub/util/dataset.py 66.66% <66.66%> (ø)
hub/integrations/pytorch.py 80.48% <100.00%> (+0.11%) ⬆️
hub/integrations/pytorch_old.py 85.41% <100.00%> (+0.31%) ⬆️
hub/integrations/tests/test_pytorch.py 82.60% <100.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b43ea...80571bb. Read the comment docs.

@tatevikh tatevikh merged commit 93686d4 into main Jul 12, 2021
@tatevikh tatevikh deleted the fix/2.0/readonly-pytorch branch July 12, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2 Everything related to Hub v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants