New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[small] pytorch readonly error bug fix #1026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change required.
Codecov Report
@@ Coverage Diff @@
## main #1026 +/- ##
=======================================
Coverage 88.61% 88.61%
=======================================
Files 86 87 +1
Lines 3916 3936 +20
=======================================
+ Hits 3470 3488 +18
- Misses 446 448 +2
Continue to review full report at Codecov.
|
please also review #1024 as this branch is based on it and they're both really small
if you tried to use pytorch on a dataset in readonly mode it would fail. this fixes it and adds a test for future proof