Refactor/fstrings #1035
Merged
Refactor/fstrings #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhiganthrao
commented
Jul 9, 2021
| @@ -157,7 +157,7 @@ def get_dataset_credentials( | |||
| Returns: | |||
| tuple: containing full url to dataset, credentials, mode and expiration time respectively. | |||
| """ | |||
| relative_url = GET_DATASET_CREDENTIALS_SUFFIX % (org_id, ds_name) | |||
| relative_url = GET_DATASET_CREDENTIALS_SUFFIX.format(org_id, ds_name) | |||
There was a problem hiding this comment.
I couldn't convert this to a fstring as it's a variable, so just decided to go with .format instead. Hope that's fine!
Codecov Report
@@ Coverage Diff @@
## main #1035 +/- ##
=======================================
Coverage 88.42% 88.42%
=======================================
Files 85 85
Lines 3897 3897
=======================================
Hits 3446 3446
Misses 451 451
Continue to review full report at Codecov.
|
farizrahman4u
approved these changes
Jul 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all instances of strings with
%sand.formatwith fstrings.