[small] remove chunk sizes from htypes #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verbose-void
changed the title
… into task/uncompressed-is-None
Codecov Report
@@ Coverage Diff @@
## main #1037 +/- ##
==========================================
+ Coverage 88.61% 88.67% +0.06%
==========================================
Files 87 86 -1
Lines 3953 3939 -14
==========================================
- Hits 3503 3493 -10
+ Misses 450 446 -4
Continue to review full report at Codecov.
|
verbose-void
commented
Jul 9, 2021
hub/htypes.py
Outdated
| @@ -42,7 +41,6 @@ | |||
|
|
|||
| # these configs are added to every `htype` | |||
| COMMON_CONFIGS = { | |||
| "chunk_size": DEFAULT_MAX_CHUNK_SIZE, | |||
| "chunk_compression": DEFAULT_CHUNK_COMPRESSION, | |||
There was a problem hiding this comment.
chunk compression is removed in #1038
farizrahman4u
approved these changes
Jul 9, 2021
update sample compression API
AbhinavTuli
reviewed
Jul 13, 2021
hub/util/exceptions.py
Outdated
| @@ -309,12 +309,23 @@ def __init__(self, htype: str, available_htypes: Sequence[str]): | |||
| class TensorMetaInvalidHtypeOverwriteValue(MetaError): | |||
| def __init__(self, key: str, value: Any, explanation: str = ""): | |||
| super().__init__( | |||
| "Invalid value {} for tensor meta key {}. {}".format( | |||
| "Invalid value '{}' for tensor meta key {}. {}".format( | |||
There was a problem hiding this comment.
let's stick to fstrings everywhere so we don't need to do fstring replacement PRs in the future.
There was a problem hiding this comment.
was an upstream change i just pulled in
AbhinavTuli
reviewed
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also removed
hub.core.typingsince it wasn't really being used