Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix for Pytorch shared memory leak #1040

Merged
merged 2 commits into from Jul 13, 2021
Merged

Conversation

AbhinavTuli
Copy link
Contributor

New pytorch was failing for datasets larger than shared memory size. This fixes it.
self.all_shared_memory was earlier used to ensure that memory wasn't dereferenced, but the logic was changed and this is no longer required.

@codecov
Copy link

codecov bot commented Jul 10, 2021

Codecov Report

Merging #1040 (6992d4c) into main (0c8b222) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1040      +/-   ##
==========================================
- Coverage   88.61%   88.61%   -0.01%     
==========================================
  Files          86       86              
  Lines        3917     3916       -1     
==========================================
- Hits         3471     3470       -1     
  Misses        446      446              
Impacted Files Coverage Δ
hub/integrations/pytorch.py 80.24% <100.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c8b222...6992d4c. Read the comment docs.

Copy link
Contributor

@verbose-void verbose-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sometimes the best solution is to make the code just a little prettier lol

@AbhinavTuli AbhinavTuli merged commit b6e5601 into main Jul 13, 2021
@AbhinavTuli AbhinavTuli deleted the fix/pytorch_shm_leak branch July 13, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants