Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tensor creation bug #1043

Merged
merged 4 commits into from Jul 12, 2021
Merged

Fix tensor creation bug #1043

merged 4 commits into from Jul 12, 2021

Conversation

farizrahman4u
Copy link
Contributor

No description provided.

@farizrahman4u farizrahman4u requested review from tatevikh and AbhinavTuli and removed request for tatevikh and AbhinavTuli July 10, 2021 16:44
@farizrahman4u farizrahman4u marked this pull request as draft July 10, 2021 16:56
@farizrahman4u farizrahman4u marked this pull request as ready for review July 10, 2021 17:00
@codecov
Copy link

codecov bot commented Jul 10, 2021 •
edited

Codecov Report

Merging #1043 (ba446b0) into main (0c8b222) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1043      +/-   ##
==========================================
+ Coverage   88.61%   88.63%   +0.02%     
==========================================
  Files          86       86              
  Lines        3917     3926       +9     
==========================================
+ Hits         3471     3480       +9     
  Misses        446      446
Impacted Files Coverage Δ
hub/api/dataset.py 92.08% <100.00%> (ø)
hub/api/tests/test_api.py 99.11% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c8b222...ba446b0. Read the comment docs.

AbhinavTuli
AbhinavTuli approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@AbhinavTuli AbhinavTuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@farizrahman4u farizrahman4u merged commit 81a5d3a into main Jul 12, 2021
@farizrahman4u farizrahman4u deleted the fr_fix_tensor_create branch July 12, 2021 14:24
@AbhinavTuli AbhinavTuli mentioned this pull request Jul 19, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhinavTuli AbhinavTuli AbhinavTuli approved these changes

@tatevikh tatevikh tatevikh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@farizrahman4u @AbhinavTuli @tatevikh