Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List datasets #1048

Merged
merged 23 commits into from Aug 3, 2021
Merged

List datasets #1048

merged 23 commits into from Aug 3, 2021

Conversation

kristinagrig06
Copy link
Contributor

@kristinagrig06 kristinagrig06 commented Jul 14, 2021 •
edited

Add CLI commands, util for getting lists of public and user datasets from the backend.

@codecov
Copy link

codecov bot commented Jul 14, 2021 •
edited

Codecov Report

Merging #1048 (501fffc) into main (a308531) will increase coverage by 0.38%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
+ Coverage   91.39%   91.78%   +0.38%     
==========================================
  Files         107      108       +1     
  Lines        5135     5207      +72     
==========================================
+ Hits         4693     4779      +86     
+ Misses        442      428      -14
Impacted Files Coverage Δ
hub/cli/list_datasets.py 81.81% <81.81%> (ø)
hub/__init__.py 100.00% <100.00%> (ø)
hub/api/dataset.py 94.66% <100.00%> (+1.61%) ⬆️
hub/cli/commands.py 100.00% <100.00%> (+100.00%) ⬆️
hub/cli/test_cli.py 100.00% <100.00%> (ø)
hub/client/client.py 94.73% <100.00%> (+2.52%) ⬆️
hub/client/config.py 100.00% <100.00%> (ø)
hub/client/test_client.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a308531...501fffc. Read the comment docs.

@kristinagrig06 kristinagrig06 requested review from AbhinavTuli and benchislett and removed request for benchislett and AbhinavTuli July 14, 2021 09:05
@kristinagrig06 kristinagrig06 marked this pull request as draft July 14, 2021 09:28
@kristinagrig06 kristinagrig06 marked this pull request as ready for review July 28, 2021 14:39
verbose-void
verbose-void approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@verbose-void verbose-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor stuff. also, this is a high quality PR

hub/__init__.py Show resolved Hide resolved
hub/api/dataset.py Outdated Show resolved Hide resolved
hub/cli/commands.py Show resolved Hide resolved
hub/cli/list_datasets.py Outdated Show resolved Hide resolved
hub/client/client.py Outdated Show resolved Hide resolved
kristinagrig06 and others added 3 commits July 30, 2021 14:27
@kristinagrig06 @verbose-void
Update docstring
056bf93 
Co-authored-by: dyllan <mccreary@dyllan.ai>
@kristinagrig06 @verbose-void
Change to hub.list
55b4c00 
Co-authored-by: dyllan <mccreary@dyllan.ai>
@kristinagrig06 @verbose-void
Update message
8637798 
Co-authored-by: dyllan <mccreary@dyllan.ai>
@kristinagrig06 kristinagrig06 merged commit 39aedfb into main Aug 3, 2021
@kristinagrig06 kristinagrig06 deleted the feature/list_datasets branch August 3, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verbose-void verbose-void verbose-void approved these changes

@AbhinavTuli AbhinavTuli AbhinavTuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kristinagrig06 @verbose-void @AbhinavTuli @davidbuniat