Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish top directory #1054

Merged
merged 11 commits into from Aug 7, 2021
Merged

Polish top directory #1054

merged 11 commits into from Aug 7, 2021

Conversation

kristinagrig06
Copy link
Contributor

Move requirements to hub, delete media folder and python version.

@kristinagrig06 kristinagrig06 marked this pull request as ready for review July 16, 2021 09:22
davidbuniat
davidbuniat previously requested changes Jul 16, 2021
View reviewed changes
Copy link
Member

@davidbuniat davidbuniat left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also move pdoc folder into somewhere else, or at least rename it to docs and then change in netlify api reference builder.

Image has also been updated.

@codecov
Copy link

codecov bot commented Jul 22, 2021 •
edited

Codecov Report

Merging #1054 (ae7ccea) into main (7aa63c5) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
+ Coverage   90.40%   90.42%   +0.01%     
==========================================
  Files         114      114              
  Lines        5533     5533              
==========================================
+ Hits         5002     5003       +1     
+ Misses        531      530       -1
Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
hub/client/client.py 94.73% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa63c5...ae7ccea. Read the comment docs.

verbose-void
verbose-void approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@verbose-void verbose-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tatevikh tatevikh requested review from farizrahman4u and removed request for davidbuniat August 5, 2021 13:57
@kristinagrig06 kristinagrig06 dismissed davidbuniat’s stale review August 6, 2021 15:56

Requested changes were made

@kristinagrig06 kristinagrig06 merged commit 78a2f3d into main Aug 7, 2021
@kristinagrig06 kristinagrig06 deleted the feature/polish_main_directory branch August 7, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@verbose-void verbose-void verbose-void approved these changes

@AbhinavTuli AbhinavTuli AbhinavTuli approved these changes

@davidbuniat davidbuniat davidbuniat left review comments

@farizrahman4u farizrahman4u Awaiting requested review from farizrahman4u

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kristinagrig06 @davidbuniat @verbose-void @AbhinavTuli