Fixes an issue in which reporting configuration file was not being created if its parent directory didn't exist. #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if the `~/.activeloop` directory did not exist, the reporting consent configuration file was not being saved and so consent checks were all coming through as False. Fixed this problem by creating the directory containing the consent file if it does not exist. This mirrors how tokens are stored when a user signs in with `activeloop login`.
`save_reporting_config` now returns the reporting configuration object it saved.
|
Tested this in Sagemaker with an unauthenticated |
verbose-void
suggested changes
Jul 16, 2021
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| __all__ = ["Dataset", "Tensor", "load", "__version__"] | |||
|
|
|||
| __version__ = "2.0.0" | |||
| __version__ = "2.0.1" | |||
There was a problem hiding this comment.
not sure we want to increment the version on this one, do we? @istranic
There was a problem hiding this comment.
ok we're good, 2.0.1 is the correct version
verbose-void
approved these changes
Jul 16, 2021
tatevikh
approved these changes
Jul 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, we create the parent directory using
os.makedirsin a manner similar to thewrite_tokenmethod inhub/client/utils.py.