Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Small PR] Removes tfds tests #1070

Merged
merged 1 commit into from Jul 21, 2021
Merged

[Small PR] Removes tfds tests #1070

merged 1 commit into from Jul 21, 2021

Conversation

AbhinavTuli
Copy link
Contributor

@AbhinavTuli AbhinavTuli commented Jul 21, 2021

馃殌 馃殌 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

-TFDS tests take up a long time on CI and aren't essential. Removing them for now.
-May cause codecov to drop slightly but should not be an issue.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #1070 (ddb0f9a) into main (514d690) will decrease coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
- Coverage   89.99%   89.51%   -0.48%     
==========================================
  Files          95       94       -1     
  Lines        4248     4227      -21     
==========================================
- Hits         3823     3784      -39     
- Misses        425      443      +18     
Impacted Files Coverage 螖
hub/util/from_tfds.py 0.00% <0.00%> (-100.00%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 514d690...ddb0f9a. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit aee55a3 into main Jul 21, 2021
@AbhinavTuli AbhinavTuli deleted the remove_tfds_test branch July 21, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants