Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias "jpg" to "jpeg" #1073

Merged
merged 4 commits into from Jul 27, 2021
Merged

Alias "jpg" to "jpeg" #1073

merged 4 commits into from Jul 27, 2021

Conversation

benchislett
Copy link
Contributor

@benchislett benchislett commented Jul 21, 2021

馃殌 馃殌 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Adds "jpg" to the supported compressions, but it is always stored internally as "jpeg". Modifies the compression test to cover both cases

@benchislett benchislett self-assigned this Jul 21, 2021
Copy link
Contributor

@verbose-void verbose-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change

hub/core/meta/tensor_meta.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #1073 (101e168) into main (86d0eb8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1073      +/-   ##
==========================================
+ Coverage   89.95%   89.97%   +0.02%     
==========================================
  Files          97       97              
  Lines        4498     4507       +9     
==========================================
+ Hits         4046     4055       +9     
  Misses        452      452              
Impacted Files Coverage 螖
hub/api/tests/test_api_with_compression.py 100.00% <100.00%> (酶)
hub/constants.py 100.00% <100.00%> (酶)
hub/core/meta/tensor_meta.py 86.44% <100.00%> (+0.35%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 86d0eb8...101e168. Read the comment docs.

Copy link
Contributor

@verbose-void verbose-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reluctant approval

@benchislett benchislett merged commit 058f9ee into main Jul 27, 2021
@benchislett benchislett deleted the task/jpeg-jpg-alias branch July 27, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants