Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info fixes #1080

Merged
merged 8 commits into from Jul 23, 2021
Merged

Info fixes #1080

merged 8 commits into from Jul 23, 2021

Conversation

farizrahman4u
Copy link
Contributor

@farizrahman4u farizrahman4u commented Jul 22, 2021

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@farizrahman4u farizrahman4u marked this pull request as draft July 22, 2021 18:02
@farizrahman4u farizrahman4u reopened this Jul 22, 2021
@farizrahman4u farizrahman4u marked this pull request as ready for review July 22, 2021 18:45
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #1080 (2b7a225) into main (86d0eb8) will increase coverage by 0.01%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1080      +/-   ##
==========================================
+ Coverage   89.95%   89.96%   +0.01%     
==========================================
  Files          97       97              
  Lines        4498     4563      +65     
==========================================
+ Hits         4046     4105      +59     
- Misses        452      458       +6     
Impacted Files Coverage Δ
hub/htypes.py 100.00% <ø> (ø)
hub/api/info.py 89.06% <80.00%> (-5.94%) ⬇️
hub/core/dataset.py 94.30% <92.30%> (-0.18%) ⬇️
hub/api/tests/test_info.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86d0eb8...2b7a225. Read the comment docs.

@@ -45,6 +45,7 @@
"class_label": {
"dtype": "uint32",
"class_names": [],
"_info": ["class_names"], # class_names should be stored in info, not meta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great

Copy link
Contributor

@verbose-void verbose-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tatevikh tatevikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@farizrahman4u farizrahman4u merged commit 3d1d98e into main Jul 23, 2021
@farizrahman4u farizrahman4u deleted the fr_info_del branch July 23, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants