New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Info fixes #1080
Info fixes #1080
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1080 +/- ##
==========================================
+ Coverage 89.95% 89.96% +0.01%
==========================================
Files 97 97
Lines 4498 4563 +65
==========================================
+ Hits 4046 4105 +59
- Misses 452 458 +6
Continue to review full report at Codecov.
|
@@ -45,6 +45,7 @@ | |||
"class_label": { | |||
"dtype": "uint32", | |||
"class_names": [], | |||
"_info": ["class_names"], # class_names should be stored in info, not meta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
🚀 🚀 Pull Request
Checklist:
coverage-rate
upChanges
Info.delte()
: https://activeloop.atlassian.net/browse/AL-1233class_names
forclass_label
htype goes to info instead of meta : https://activeloop.atlassian.net/browse/AL-1234