Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugout reporting update #1081

Merged
merged 5 commits into from Jul 23, 2021
Merged

Bugout reporting update #1081

merged 5 commits into from Jul 23, 2021

Conversation

istranic
Copy link
Contributor

馃殌 馃殌 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

  • Updated Bugout reporting to make more sense with the new dataset API

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #1081 (f55651c) into main (86d0eb8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1081      +/-   ##
==========================================
+ Coverage   89.95%   89.97%   +0.02%     
==========================================
  Files          97       97              
  Lines        4498     4507       +9     
==========================================
+ Hits         4046     4055       +9     
  Misses        452      452              
Impacted Files Coverage 螖
hub/api/dataset.py 89.28% <100.00%> (+1.53%) 猬嗭笍
hub/core/dataset.py 94.55% <100.00%> (+0.07%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 86d0eb8...f55651c. Read the comment docs.

@istranic istranic changed the title Istranic reporting update Bugout reporting update Jul 22, 2021
Copy link
Contributor

@verbose-void verbose-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting is failing, DM me for approval

@istranic istranic requested review from verbose-void and davidbuniat and removed request for AbhinavTuli July 23, 2021 12:12
@verbose-void verbose-void merged commit 4ddfe7d into main Jul 23, 2021
@verbose-void verbose-void deleted the istranic-reporting-update branch July 23, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants