Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

More sample compressions #1087

Merged
merged 11 commits into from Aug 6, 2021
Merged

More sample compressions #1087

merged 11 commits into from Aug 6, 2021

Conversation

farizrahman4u
Copy link
Contributor

@farizrahman4u farizrahman4u commented Jul 28, 2021

馃殌 馃殌 Pull Request

https://activeloop.atlassian.net/browse/AL-1189

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Add bmp and gif

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #1087 (c5691b4) into main (7aa63c5) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1087      +/-   ##
==========================================
+ Coverage   90.40%   90.44%   +0.04%     
==========================================
  Files         114      114              
  Lines        5533     5558      +25     
==========================================
+ Hits         5002     5027      +25     
  Misses        531      531              
Impacted Files Coverage 螖
hub/constants.py 100.00% <100.00%> (酶)
hub/core/compression.py 85.71% <100.00%> (-0.96%) 猬囷笍
hub/core/meta/tensor_meta.py 91.83% <100.00%> (+0.17%) 猬嗭笍
hub/core/sample.py 87.67% <100.00%> (+0.34%) 猬嗭笍
hub/core/tests/test_compression.py 100.00% <100.00%> (酶)
hub/tests/path_fixtures.py 88.88% <100.00%> (+1.05%) 猬嗭笍
hub/client/client.py 94.73% <0.00%> (+1.05%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 7aa63c5...c5691b4. Read the comment docs.

hub/constants.py Outdated Show resolved Hide resolved
Copy link
Contributor

@verbose-void verbose-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes

farizrahman4u and others added 3 commits July 31, 2021 01:14
Copy link
Contributor

@verbose-void verbose-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i saw you snuck sample.__array__ in there, nice lil surprise

@farizrahman4u
Copy link
Contributor Author

farizrahman4u commented Aug 5, 2021

i saw you snuck sample.__array__ in there, nice lil surprise

drawing

@farizrahman4u farizrahman4u merged commit 277010b into main Aug 6, 2021
@farizrahman4u farizrahman4u deleted the fr_compr branch August 6, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants