kaggle argument fix #1101
Merged
kaggle argument fix #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verbose-void
reviewed
Aug 4, 2021
verbose-void
reviewed
Aug 4, 2021
hub/api/dataset.py
Outdated
| @@ -370,6 +371,7 @@ def ingest_kaggle( | |||
| - a local file system path of the form ./path/to/dataset or ~/path/to/dataset or path/to/dataset. | |||
| - a memory path of the form mem://path/to/dataset which doesn't save the dataset but keeps it in memory instead. Should be used only for testing as it does not persist. | |||
| dest_creds (dict): A dictionary containing credentials used to access the destination path of the dataset. | |||
| kaggle_credentials (dict): A dictionary containing kaggle credentials {"username":"", "key": ""}. | |||
There was a problem hiding this comment.
Suggested change
| kaggle_credentials (dict): A dictionary containing kaggle credentials {"username":"", "key": ""}. | |
| kaggle_credentials (dict): A dictionary containing kaggle credentials {"username":"YOUR_USERNAME", "key": "YOUR_KEY"}. If None, environment variables/the kaggle.json file will be used if available. |
verbose-void
reviewed
Aug 4, 2021
verbose-void
approved these changes
Aug 4, 2021
AbhinavTuli
reviewed
Aug 5, 2021
Codecov Report
@@ Coverage Diff @@
## main #1101 +/- ##
==========================================
- Coverage 90.72% 90.60% -0.12%
==========================================
Files 118 118
Lines 6051 6059 +8
==========================================
Hits 5490 5490
- Misses 561 569 +8
Continue to review full report at Codecov.
|
|
This is a tiny fix, please approve. It fixes a critical bug with ingest_kaggle() API. |
AbhinavTuli
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃殌 馃殌 Pull Request
Checklist:
coverage-rateupChanges
add missing kaggle-credentials argument
tiny fix - pls approve