Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban dataset attributes as tensor names #1103

Merged
merged 4 commits into from Aug 6, 2021
Merged

Conversation

kristinagrig06
Copy link
Contributor

@kristinagrig06 kristinagrig06 commented Aug 6, 2021

馃殌 馃殌 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Add check for reserved names in .create_tensor().

Copy link
Contributor

@farizrahman4u farizrahman4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve after tests are added.

hub/core/dataset.py Outdated Show resolved Hide resolved
hub/core/dataset.py Show resolved Hide resolved
kristinagrig06 and others added 2 commits August 6, 2021 13:59
Co-authored-by: Fariz Rahman <farizrahman4u@gmail.com>
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #1103 (ae2bd45) into main (277010b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
+ Coverage   90.44%   90.46%   +0.02%     
==========================================
  Files         114      114              
  Lines        5558     5570      +12     
==========================================
+ Hits         5027     5039      +12     
  Misses        531      531              
Impacted Files Coverage 螖
hub/api/tests/test_api.py 99.31% <100.00%> (+0.01%) 猬嗭笍
hub/core/dataset.py 95.69% <100.00%> (+0.04%) 猬嗭笍
hub/util/exceptions.py 78.57% <100.00%> (+0.27%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 277010b...ae2bd45. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit fa1f731 into main Aug 6, 2021
@AbhinavTuli AbhinavTuli deleted the fix/ban_api_tensor_names branch August 6, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants