Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/num workers 0 bug #1112

Merged
merged 10 commits into from Aug 11, 2021
Merged

Fix/num workers 0 bug #1112

merged 10 commits into from Aug 11, 2021

Conversation

davidbuniat
Copy link
Member

馃殌 馃殌 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

To fix the issue reported by @DebadityaPal on num_workers=0 for compute

Copy link
Contributor

@verbose-void verbose-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use parametrize + remove retrying and ping me for re-review

Copy link
Contributor

@AbhinavTuli AbhinavTuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a related fix to allow memory datasets to work with serial/0 worker transforms and removed the xfail from the new test. Will re-review once unrelated code for retries is removed and parametrization is added.

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #1112 (6a8d1eb) into main (3d597ac) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1112      +/-   ##
==========================================
+ Coverage   90.61%   90.68%   +0.07%     
==========================================
  Files         118      118              
  Lines        6071     6077       +6     
==========================================
+ Hits         5501     5511      +10     
+ Misses        570      566       -4     
Impacted Files Coverage 螖
hub/__init__.py 100.00% <100.00%> (酶)
hub/core/transform/test_transform.py 96.81% <100.00%> (+0.04%) 猬嗭笍
hub/core/transform/transform.py 96.66% <100.00%> (+1.75%) 猬嗭笍
hub/tests/common.py 96.22% <100.00%> (+0.22%) 猬嗭笍
hub/util/transform.py 91.50% <100.00%> (酶)
hub/util/compute.py 91.66% <0.00%> (+8.33%) 猬嗭笍
hub/core/compute/serial.py 100.00% <0.00%> (+33.33%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3d597ac...6a8d1eb. Read the comment docs.

Copy link
Contributor

@verbose-void verbose-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@davidbuniat davidbuniat merged commit 4e84e1c into main Aug 11, 2021
@davidbuniat davidbuniat deleted the fix/num_workers_0_bug branch August 11, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants