New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/num workers 0 bug #1112
Fix/num workers 0 bug #1112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use parametrize + remove retrying and ping me for re-review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a related fix to allow memory datasets to work with serial/0 worker transforms and removed the xfail from the new test. Will re-review once unrelated code for retries is removed and parametrization is added.
Codecov Report
@@ Coverage Diff @@
## main #1112 +/- ##
==========================================
+ Coverage 90.61% 90.68% +0.07%
==========================================
Files 118 118
Lines 6071 6077 +6
==========================================
+ Hits 5501 5511 +10
+ Misses 570 566 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
馃殌 馃殌 Pull Request
Checklist:
coverage-rate
upChanges
To fix the issue reported by @DebadityaPal on num_workers=0 for compute