Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move transform reporting to pipeline eval #1116

Merged
merged 2 commits into from Aug 11, 2021
Merged

Move transform reporting to pipeline eval #1116

merged 2 commits into from Aug 11, 2021

Conversation

istranic
Copy link
Contributor

馃殌 馃殌 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@@ -98,6 +93,11 @@ def eval(
if isinstance(data_in, hub.core.dataset.Dataset):
data_in = get_dataset_with_zero_size_cache(data_in)

hub_reporter.feature_report(
feature_name="eval",
parameters={"Num_Workers": num_workers, "Scheduler": scheduler},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@istranic mypy (which is doing type inference) was warning that num_workers is of type int however expects str, should we wrap str(num_workers)

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #1116 (df8c6b2) into main (3a5f7c9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1116   +/-   ##
=======================================
  Coverage   90.61%   90.61%           
=======================================
  Files         118      118           
  Lines        6071     6071           
=======================================
  Hits         5501     5501           
  Misses        570      570           
Impacted Files Coverage 螖
hub/core/transform/transform.py 94.91% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3a5f7c9...df8c6b2. Read the comment docs.

@istranic istranic merged commit e34d67c into main Aug 11, 2021
@istranic istranic deleted the fix/2.0/reporter branch August 11, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants