Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version control locking #1343

Merged
merged 17 commits into from
Dec 15, 2021
Merged

Version control locking #1343

merged 17 commits into from
Dec 15, 2021

Conversation

farizrahman4u
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2021

CLA assistant check
All committers have signed the CLA.

hub/core/dataset/dataset.py Outdated Show resolved Hide resolved
hub/core/lock.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #1343 (1cdd582) into main (e7df28b) will increase coverage by 0.03%.
The diff coverage is 93.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1343      +/-   ##
==========================================
+ Coverage   92.85%   92.89%   +0.03%     
==========================================
  Files         174      175       +1     
  Lines       12793    12954     +161     
==========================================
+ Hits        11879    12033     +154     
- Misses        914      921       +7     
Flag Coverage Δ
unittests 92.89% <93.20%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/lock.py 85.24% <75.92%> (-5.87%) ⬇️
hub/core/dataset/dataset.py 94.29% <96.66%> (+0.27%) ⬆️
hub/constants.py 100.00% <100.00%> (ø)
hub/core/tests/test_locking.py 100.00% <100.00%> (ø)
hub/core/version_control/commit_node.py 100.00% <100.00%> (ø)
hub/tests/dataset_fixtures.py 100.00% <100.00%> (ø)
hub/util/keys.py 100.00% <100.00%> (ø)
hub/util/tests/test_version_control.py 100.00% <100.00%> (ø)
hub/util/version_control.py 96.94% <100.00%> (+0.62%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7df28b...1cdd582. Read the comment docs.

hub/constants.py Outdated Show resolved Hide resolved
hub/core/lock.py Outdated Show resolved Hide resolved
Copy link
Contributor

@AbhinavTuli AbhinavTuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but would like to see more codecov in version_control methods

@farizrahman4u farizrahman4u merged commit 619be82 into main Dec 15, 2021
@farizrahman4u farizrahman4u deleted the fr_vc_locks branch December 15, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants