Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-1613][AL-1549] Send events from Hub to Platform #1406

Merged
merged 30 commits into from
Dec 28, 2021
Merged

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

hub/client/client.py Outdated Show resolved Hide resolved
hub/core/query/filter.py Outdated Show resolved Hide resolved
Copy link
Contributor

@farizrahman4u farizrahman4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must consider queueing requests and sending them async from a daemon thread.

hub/__init__.py Outdated Show resolved Hide resolved
hub/core/query/filter.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #1406 (5a17f55) into main (b20e4c1) will increase coverage by 0.01%.
The diff coverage is 93.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1406      +/-   ##
==========================================
+ Coverage   92.26%   92.27%   +0.01%     
==========================================
  Files         174      176       +2     
  Lines       13954    14092     +138     
==========================================
+ Hits        12874    13003     +129     
- Misses       1080     1089       +9     
Flag Coverage Δ
unittests 92.27% <93.83%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/query/query.py 86.80% <ø> (ø)
hub/core/query/filter.py 75.00% <70.00%> (-4.55%) ⬇️
hub/__init__.py 93.33% <83.33%> (-3.64%) ⬇️
hub/core/dataset/hub_cloud_dataset.py 91.74% <91.89%> (-0.15%) ⬇️
hub/core/dataset/dataset.py 93.77% <96.77%> (+0.11%) ⬆️
hub/util/version_control.py 98.12% <96.96%> (+0.47%) ⬆️
hub/api/info.py 87.50% <100.00%> (+1.13%) ⬆️
hub/api/tests/test_events.py 100.00% <100.00%> (ø)
hub/client/client.py 95.00% <100.00%> (+0.10%) ⬆️
hub/client/config.py 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b20e4c1...5a17f55. Read the comment docs.

@AbhinavTuli AbhinavTuli changed the title [AL-1613] Send events from Hub to Platform [AL-1613][AL-1549] Send events from Hub to Platform Dec 28, 2021
@AbhinavTuli AbhinavTuli merged commit 2e815f9 into main Dec 28, 2021
@AbhinavTuli AbhinavTuli deleted the platform/events branch December 28, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants