Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-1631] Commit with custom hash #1408

Merged
merged 6 commits into from
Dec 24, 2021
Merged

[AL-1631] Commit with custom hash #1408

merged 6 commits into from
Dec 24, 2021

Conversation

farizrahman4u
Copy link
Contributor

馃殌 馃殌 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

https://activeloop.atlassian.net/browse/AL-1631

@CLAassistant
Copy link

CLAassistant commented Dec 23, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #1408 (14a7905) into main (83146b3) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1408      +/-   ##
==========================================
+ Coverage   92.22%   92.25%   +0.03%     
==========================================
  Files         174      174              
  Lines       13906    13949      +43     
==========================================
+ Hits        12825    12869      +44     
+ Misses       1081     1080       -1     
Flag Coverage 螖
unittests 92.25% <100.00%> (+0.03%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
hub/core/dataset/dataset.py 93.64% <100.00%> (+0.11%) 猬嗭笍
hub/core/version_control/test_version_control.py 99.86% <100.00%> (+<0.01%) 猬嗭笍
hub/util/exceptions.py 80.06% <100.00%> (+0.14%) 猬嗭笍
hub/util/version_control.py 97.64% <100.00%> (+0.48%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 83146b3...14a7905. Read the comment docs.

Copy link
Contributor

@AbhinavTuli AbhinavTuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, need to add tests though.

@farizrahman4u farizrahman4u merged commit cc0fa64 into main Dec 24, 2021
@farizrahman4u farizrahman4u deleted the fr_custom_commit_hash branch December 24, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants