Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable intellisense for hub compute functions #1419

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

  • Functions decorated with @hub.compute will now show proper IntelliSense while using .eval()
  • Changed class name from TransformFunction to ComputeFunction

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #1419 (9c786f6) into main (5662c3a) will decrease coverage by 0.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
- Coverage   92.33%   91.72%   -0.61%     
==========================================
  Files         176      176              
  Lines       14204    14006     -198     
==========================================
- Hits        13115    12847     -268     
- Misses       1089     1159      +70     
Flag Coverage Δ
unittests 91.72% <100.00%> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/transform/transform.py 95.61% <100.00%> (ø)
hub/util/transform.py 92.07% <100.00%> (ø)
hub/api/tests/test_api_with_compression.py 89.85% <0.00%> (-10.15%) ⬇️
hub/core/lock.py 77.04% <0.00%> (-8.20%) ⬇️
hub/core/tests/test_compression.py 94.39% <0.00%> (-5.61%) ⬇️
hub/tests/path_fixtures.py 88.27% <0.00%> (-3.78%) ⬇️
hub/core/fast_forwarding.py 66.66% <0.00%> (-2.30%) ⬇️
hub/core/compression.py 87.33% <0.00%> (-2.27%) ⬇️
hub/api/tests/test_api.py 97.74% <0.00%> (-2.26%) ⬇️
hub/core/meta/tensor_meta.py 84.75% <0.00%> (-1.92%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5662c3a...9c786f6. Read the comment docs.

@farizrahman4u farizrahman4u merged commit b90fa83 into main Dec 30, 2021
@farizrahman4u farizrahman4u deleted the type_hinting_eval branch December 30, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants