Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed auth token request method to POST #1440

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Conversation

Diveafall
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Copy link
Member

@davidbuniat davidbuniat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge until all production backend related issues pass

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #1440 (54dfd9c) into main (cfbe338) will increase coverage by 0.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1440      +/-   ##
==========================================
+ Coverage   91.50%   92.12%   +0.61%     
==========================================
  Files         175      175              
  Lines       14018    14215     +197     
==========================================
+ Hits        12827    13095     +268     
+ Misses       1191     1120      -71     
Flag Coverage Δ
unittests 92.12% <100.00%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/client/client.py 95.00% <100.00%> (ø)
hub/cli/commands.py 100.00% <0.00%> (ø)
hub/api/tests/test_json.py 100.00% <0.00%> (ø)
hub/api/tests/test_text.py 100.00% <0.00%> (ø)
hub/tests/cache_fixtures.py 100.00% <0.00%> (ø)
hub/api/tests/test_events.py 100.00% <0.00%> (ø)
hub/api/tests/test_pickle.py 100.00% <0.00%> (ø)
hub/core/storage/provider.py 100.00% <0.00%> (ø)
hub/core/meta/dataset_meta.py 100.00% <0.00%> (ø)
hub/tests/dataset_fixtures.py 100.00% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfbe338...54dfd9c. Read the comment docs.

@Diveafall Diveafall dismissed davidbuniat’s stale review January 25, 2022 18:37

Got a green light from Tatevik to proceed with this.

@Diveafall Diveafall merged commit b4ca1ff into main Jan 25, 2022
@Diveafall Diveafall deleted the fix/get-token-request-method branch January 25, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants