Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AL-1619][AL-1586] Removes cachable, makes Info more dict like #1469
[AL-1619][AL-1586] Removes cachable, makes Info more dict like #1469
Changes from 36 commits
8316498
63da480
7a1c168
6eaf915
c6ecc9b
80aa8b9
2a6ecfb
2ffa0d5
f38d998
340136c
b9d8a54
5e2183f
919bc25
6ecd2c8
bc13622
b08ec0b
ba48d30
326861a
3cf44db
c053b28
0095a0f
efd3561
9788aca
56ee27f
4c98176
bf1ab74
bc75517
1a39dec
9da2d87
befccb0
9eeec9a
d057ff4
ff72c3a
438bdf8
58af3d7
4da514d
e8f34be
97bc46f
dbe28fb
97ebcb7
8fb8067
2dbc9ab
45199b8
1c3c558
eca4fd0
81ca4b2
725c2a3
d39b4a9
10003cf
b4b1904
a06e4af
ceba68c
e1b9857
274a9d8
ddb218f
7b4e83e
72b4a7f
81032ab
e4f13c0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this change doesn't look to be backward compatible, hub version needs to be appropriately bumped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a slight change in API for info, delete is barely used atm, we should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate tests for some of these methods (like popitem) might be better -- LIFO popitem not obvious here :)